[Libreoffice] ODBC handles, a quibble

Lionel Elie Mamane lionel at mamane.lu
Sun Oct 9 06:09:07 PDT 2011

On Tue, Oct 04, 2011 at 12:27:11PM -0400, Terrence Enger wrote:
> On Tue, 2011-10-04 at 11:27 +0100, Michael Meeks wrote:
>> On Fri, 2011-09-30 at 14:13 -0400, Terrence Enger wrote:

>>> My interest is in the fractions of seconds in times and
>>> timestamps, an interest provoked by bug 34309 "Error on importing
>>> a timestamp field from db2 via ODBC"
>>> <https://bugs.freedesktop.org/show_bug.cgi?id=34309>.

>> 	Nice - thanks for your help & testing there, looks like we're blocking
>> on some input from Lionel - I guess if we don't get that in a few days,
>> and it seems to work we should just commit your patch :-)

> (*) Caolán's patch fixes also
>     ODatabaseMetaDataResultSet::getTimestamp.  (Hunh?  
>     Why does the diff say that the changed line is in
>     ODatabaseMetaDataResultSet::getShort?  I still think the
>     changed function is getTimestamp.)

My guess is that diff gets confused by C++ syntax it does not
recognise; it knows only C syntax. My guess in this case is that the
part that confuses it is the namespace separator "::"; it does not
recognise getString, getTime, getTimestamp as new functions because
their return type starts (or contains) "::".

Just ignore the function that diff reports :) (Or send a patch to GNU
diffutils so that it recognises C++ syntax ;-) )


More information about the LibreOffice mailing list