[Libreoffice] [PATCH] String::CompareIngoreCaseToAscii

[August Sodora]

I'm sure these things are easier to troubleshoot when I remember to
include the patch :)


August Sodora
augsod at gmail.com
(201) 280-8138



On Mon, Oct 17, 2011 at 10:01 AM, August Sodora <augsod at gmail.com> wrote:
>> I am terribly sorry, but got distracted by the LibreOffice conference,
>> and was not able to have a look at your updated patch :-(
>
> No worries :) It gave me a lot of good time to read the code and try
> to understand the problem better.
>
>> If you have any tests now, would be great to send them too, I believe it
>> will help me evaluate your patch too.
>
> I started writing a test fixture to try and pull apart exactly what is
> going on in the basic scanner but I ran into a build issue. I followed
> the instructions on
> http://wiki.documentfoundation.org/Development/Unit_Tests but get some
> errors:
>
> /home/aasodora/Sources/libo/basic/qa/cppunit/test_scanner.cxx:78:
> undefined reference to `SbiScanner::SbiScanner(rtl::OUString const&,
> StarBASIC*)'
>
> Sorry for being such a noob, thank you all for your patience!
>
> August Sodora
> augsod at gmail.com
> (201) 280-8138
>
>
>
> On Mon, Oct 17, 2011 at 8:58 AM, Jan Holesovsky <kendy at suse.cz> wrote:
>> Hi August,
>>
>> On 2011-10-07 at 16:01 -0400, August Sodora wrote:
>>
>>> Has anybody had a chance to review this patch? I'm really interested
>>> in writing some tests for basic and I'd like to make sure that these
>>> types of changes are on the right track.
>>
>> I am terribly sorry, but got distracted by the LibreOffice conference,
>> and was not able to have a look at your updated patch :-(
>>
>> If you have any tests now, would be great to send them too, I believe it
>> will help me evaluate your patch too.
>>
>> Thank you a lot,
>> Kendy
>>
>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: basic_tests.patch
Type: text/x-patch
Size: 4163 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111017/ecf41dc6/attachment.bin>