[Libreoffice] pre patch question
kaplanlior at gmail.com
Mon Oct 17 11:53:08 PDT 2011
On Fri, Oct 14, 2011 at 8:50 PM, Michael Meeks <michael.meeks at suse.com>wrote:
> Hi Lior,
> On Thu, 2011-10-13 at 23:52 +0200, Lior Kaplan wrote:
> > While doing some translation today, I've saw a few strings about
> > installation media types. While that's nice, I believe that no one
> > will try to install LibreOffice for a 5.25" disk or from a tape drive
> > (and good luck if you do try that (: ).
> Sure ! :-) this is a nice scope for cleanup ...
> So for this case I suggest we remove all of the obsolete ".chaos"
> prefixed URLs that specify the "tmp" extension in the relevant array in
> inettype.cxx & the hrc entries that are related in svl.hrx, and of
> course the enum entries in inettype.hxx - and of course also compact the
> enumerations and CONTENT_TYPE_LAST as well :-)
> Actually these days we use SAL_N_ELEMENTS() instead of this
> CONTENT_TYPE_LAST stuff which is safer wrt. patching.
> Is that do-able ? :-) it'd be nice to have a test compile too ...
I'm attaching 3 patches:
1. Bulk removal.
2. Compact the enumeration.
3. Just align a string (no change in content).
More information about the LibreOffice