[Libreoffice] memory leak or tricky LO foo?

Eike Rathke ooo at erack.de
Wed Oct 19 06:00:58 PDT 2011


Hi Kevin,

On Wednesday, 2011-10-05 02:01:24 -0400, Kevin Hunter wrote:

> In idly reading LO code (trying yet again to spend time wrapping my
> head around anything in the code base), 

Great :)

> I'm puzzled by this snippet
> (with minor format alteration for email) from
> svl/source/numbers/zforlist.cxx (currently around line 2226).  It
> seems to me that pNewFormat is a memory leak, but I don't know the
> LO well enough to state that. Specifically, is aFTable.Insert saving
> the pointed to memory?

aFTable takes ownership of the pointer, hence the delete only after an
unsuccessful Insert(). See SvNumberFormatter dtor where entries are
deleted.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111019/af8aed26/attachment.pgp>


More information about the LibreOffice mailing list