[Libreoffice] [GSoC 2011][svgexport][PATCH] Fixed a buf in the JavaScript animation engine

[Marco]

On Tue, 30 Aug 2011 15:13:09 +0200, Thorsten Behrens  
<thb at documentfoundation.org> wrote:

> Marco wrote:
>> Ok sorry, I have no knowledge of software legal issues.
>> So should I remove such a change ?
>>
> Yes please.
>
>> Yep, I was thinking of that by a while, what stopped me from
>> deploying such a solution is: - it is not clear to me how to get
>> the python script executed automatically (make file ?);
>> - it does not seem that python is listed between the requirements
>> to get LibreOffice built.
>>
> No prob, those can be custom-built. If you can share original .js
> and the python script, we'll have that setup.
>

Hi Thorsten,
I attached the JavaScript presentation engine used for the last patch
I sent to you, except that I reverted the change related to Open
Office legal notice.
I attached also the python script I used for generating the C++
header, at present it works in the following way:

script_header_generator.py <input javascript file> <output file name>

The output file is created in the folder where the python script is
launched. Any '//', '/n', '/t' escape sequence is replaced by,
respectively, '////', '//n', '//t', as a single backslash '/' inside
a C/C++ string means that the string continues on the next line.
Any single or multi-line comment is striped, except for multi-line
comments starting with '/' and exactly 5 '*'. For safety I inserted
the following remark at the beginning of the JavaScript file:

/**
  *  WARNING: any comment that should not be striped out by the
  *  script generating the C++ header file must starts with a '/'
  *  and exactly 5 '*';
  *  not striped examples: '/*****', '/***** *'
  *  striped examples: '/** ***' (not contiguous),
  *                    '/******' (more than 5)
  */


All legal notice conform to such a rule.


In case the python script catches the presence of a '"' it prints
a warning message out, specifying the location (row and column)
of the '"' inside the input file. Anyhow it does not stop generating
the header file and ends with exit code 0.

At present the python script ends with a non-zero exit code, when
it is not able to find the input file, or to create the output file.


You are free to modify the python script as you like, for adapting
it to the automated header generation process, and to append any
legal notice you think appropriate.


In the next days I'll go to clone the One Git repo and build it.

Cheers,
-- Marco


-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: presentation_engine.js.tar.gz
Type: application/x-gzip
Size: 47862 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110901/c622550f/attachment-0001.bin>