[Libreoffice] map files: how to update? [was: cppu::OPropertySetHelper ABI backwards compatibility]

[Lionel Elie Mamane]

On Thu, Aug 25, 2011 at 10:10:16PM +0200, Stephan Bergmann wrote:

> A number of comments on the patch:

> - The OPropertySetHelper2 ctor(s) should not be inline.  (See how eventually making use of OPropertySetHelper::m_pReserved would not have worked if OPropertySetHelper's ctors had been inline.)

Yes, good catch.

> - For the question of which symbols for OPropertySetHelper2 to list
> in the various map files, see
> <http://udk.openoffice.org/common/man/apicppclasses.html> (you
> probably need access to builds on the various platforms to find out
> the correct mangled names).

It does not say to export the vtable; I assume the vtable "obviously"
has to be exported.

It says:

  If the destructor of a class is declared virtual, declare the
  destructors of all its base classes virtual. (To have a dedicated
  place where RTTI for the base classes is generated, which is
  referenced by the RTTI for the derived class. Since in general you
  cannot control the ways a class is used, the best advice probably is
  to do this for each class that is intended to be subclassed.)

Well, we cannot do that anymore, since that would break ABI on
OPropertySetHelper2. Can we "safely" ignore this instruction here?


Revised patch attached; if it is good to go (especially with respect
to questions above), I'll commit (with a better commit message).

-- 
Lionel