[Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.

[Stephan Bergmann]

On 09/06/2011 12:25 PM, Noel Power wrote:
> Hi Stephan,
> On 06/09/11 10:07, Stephan Bergmann wrote:
>> Found a regression from a recent "Disable fake VBA events for the
>> old-style form controls" commit that causes the forms/qa/unoapi check
>> to fail. Attached patch fixes it.
>>
>> -Stephan
> thanks for fixing, ( I see Caolán pushed ) btw what exactly was null /me
> just doesn't see where/why moving the getPropertyValue makes a difference.

The unoapi tests call insertByIndex with a null interface, 
approveNewElement called from OInterfaceContainer::implInsert checks for 
null and throws an exception, but your modification accessed _rxElement 
before it got passed to approveNewElement.

-Stephan