[Libreoffice] [REVIEW] undo/redo inserting cells in merged cells with shadows result in strange behavior

Eike Rathke ooo at erack.de
Wed Sep 7 07:46:44 PDT 2011


Hi Markus,

On Tuesday, 2011-09-06 21:47:16 +0200, Markus Mohrhard wrote:

> this patch removes some code that resulted in strange behavior with merged
> areas and shadows.

That doesn't look right. ExtendMerge() includes a row/column that is
affected by the merged area's shadow and needs to be repainted after
redo.

> The code extended the merged area by one column/row which
> resulted in strange behavior with undo/redo.

And the strange behavior is?

> It seems that the code was an
> old hack for the ui part that is no longer needed.

I doubt that. Or what did change in that area?

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110907/d35a9a50/attachment.pgp>


More information about the LibreOffice mailing list