[Libreoffice] [PUSHED] cppcheck cleanliness: duplicate expression

[Korrawit Pruegsanusak]

Hello Eike, Stephan, *

On Thu, Sep 8, 2011 at 17:23, Eike Rathke <ooo at erack.de> wrote:
> It didn't occur to me that the original expression
> actually would had been wrong at two places..

Also for me too. My bad for didn't notice it.

> On Thursday, 2011-09-08 08:40:24 +0200, Stephan Bergmann wrote:
>> Now actually looking at the context:  Given that CmpKernData in
>> vcl/source/gdi/outdev3.cxx is (only) used as an argument to
>> std::sort, I'm pretty sure it must read (a.nChar1 == b.nChar1) to
>> make that a true strict weak ordering, as required by std::sort.
>> Pushed as <http://cgit.freedesktop.org/libreoffice/core/commit/?id=8b7978c822b11c53b4bd40bb0829e3ec205f1359>.

And thanks very much for pushing this. ;)

Best Regards,
-- 
Korrawit Pruegsanusak