[Libreoffice] cppcheck duplicate if expressions in bulmaper.cxx (sd part)

Stephan Bergmann sbergman at redhat.com
Thu Sep 8 23:19:10 PDT 2011


On 09/08/2011 10:47 PM, julien2412 wrote:
> Here is the pb :
>              if( 0 )<--- Found duplicate if expressions.
>              {
>                  nFontID = EE_CHAR_FONTINFO_CJK;
>                   nFontHeightID = EE_CHAR_FONTHEIGHT_CJK;
>                  nWeightID = EE_CHAR_WEIGHT_CJK;
>                  nPostureID = EE_CHAR_ITALIC_CJK;
>              }
>              else if( 0 )
>              {
>                  nFontID = EE_CHAR_FONTINFO_CTL;
>                   nFontHeightID = EE_CHAR_FONTHEIGHT_CTL;
>                  nWeightID = EE_CHAR_WEIGHT_CTL;
>                  nPostureID = EE_CHAR_ITALIC_CTL;
>              }
> I checked the history, it's there since 16/11/2000 (commit
> 5dc708093d1ee179099abdcbf0c6f649b1c4deeb)
>
> could anyone explain to me the purpose of this ? Just a typo ?

It's preceded by comment "to be implemented if module supports CJK" a 
few lines above at sd/source/ui/func/bulmaper.cxx:73, so I would say its 
something like commented-out code that still awaits implementation...

-Stephan


More information about the LibreOffice mailing list