[Libreoffice] [Review] simple bugfix (too simple ?)

[Eike Rathke]

Hi Julien,

On Sunday, 2011-09-11 22:53:45 +0200, Julien Nabet wrote:

> @@ -124,7 +124,7 @@ void createSettingsStructure(xmlDoc * document,
> bool * bNeedsSave)
>      }
>      if (bFound)
>      {
> -        bNeedsSave = false;
> +        *bNeedsSave = false;
>          return;
>      }
>      //We will modify this document
> 
> Too simple to be true ? I prefer asking instead of having missed a
> "special C++ trick".

There's no special trick involved here ;-)
The only caller of createSettingsStructure() passes a bool* and one line
below your diff there's also

    //We will modify this document
    *bNeedsSave = true;

> (As usual, I can of course commit and push it on master if it's ok).

Do so. Btw, apparently the current code leads to the document not being
saved at this place if it should.. hopefully it's saved later anyway.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110912/ed61c714/attachment.pgp>