[Libreoffice] duplicateif in vcl/source/gdi/outdev3.cxx

Stephan Bergmann sbergman at redhat.com
Wed Sep 14 13:25:33 PDT 2011


On 09/14/2011 08:47 PM, julien2412 wrote:
> Since I don't know the impact I prefer proposing a review.
> Of course, if you're really sure of you Eike (:-) ), I can commit and push
> right away on master
>
> http://nabble.documentfoundation.org/file/n3336763/patch_outdev3.txt
> patch_outdev3.txt

Looking at the code, I am pretty sure the first use of nMatchType should 
be nSearchType instead.  That is, the code should check whether 
nSearchType and nMatchType have differing settings of OTHERSTYLE and 
then pessimize nTestMatch by 10,000.

Pushed now as 
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=b6cccb9e77111254932ebcf96f883aab04cb3f56>.

-Stephan


More information about the LibreOffice mailing list