[Libreoffice] [Libreoffice-commits] .: Branch 'libreoffice-3-4' - solenv/gbuild

[Norbert Thiebaud]

On Mon, Sep 19, 2011 at 5:34 PM, Bjoern Michaelsen
<bjoern.michaelsen at canonical.com> wrote:
> On Mon, 19 Sep 2011 23:20:32 +0200
> Stephan Bergmann <sbergman at redhat.com>
> wrote:
>
>> What good is that backport to 3.4?
>
> Well, it is a clearcut regression (the error was introduced between
> 3.3 and 3.4) and a good fix (even breaking on link is better than
> breaking at runtime) -- so I automatically backported after review.
> Other than the "needs one signoff"-rule, we have little guidelines on
> what goes on the release branch. Maybe we should be a little more
> strict. But I guess still no revert needed?

well... not so fast... the patch does not fix everything, just make it
blow earlier...

first in i18npool where gencoll_rule is not happy because it does not
have a LAYER defined for it

then
illegal combination app/NONEBIN/OOO at
/Volumes/Raid0/core/solenv/bin/macosx-change-install-names.pl line 56,
<IN> line 2.
make[1]: *** [/Volumes/Raid0/core/workdir/unxmacxi.pro/LinkTarget/Executable/mkunroll]
Error 9
make[1]: *** Waiting for unfinished jobs....
illegal combination app/NONEBIN/URELIB at
/Volumes/Raid0/core/solenv/bin/macosx-change-install-names.pl line 56,
<IN> line 2.
make[1]: *** [/Volumes/Raid0/core/workdir/unxmacxi.pro/LinkTarget/Executable/so_checksum]
Error 9
illegal combination app/NONEBIN/OOO at
/Volumes/Raid0/core/solenv/bin/macosx-change-install-names.pl line 56,
<IN> line 2.
make[1]: *** [/Volumes/Raid0/core/workdir/unxmacxi.pro/LinkTarget/Executable/rscdep]
Error 9
dmake:  Error code 2, while making 'all'

so 3.4 may have accidentally worked because nothing that produce
delivered Executable was gbuildified... but at least it was
'working'... with that patch alone I'm afraid 3.4 may not build
anymore on MacOSX...

Norbert