[Libreoffice] [PATCH] bug fdo#37164
Noel Power
nopower at suse.com
Tue Sep 20 01:59:08 PDT 2011
Hi,
The automation testtool thingy is broken on 3.4 ( and master too... but
that's a different story )
The root cause of the problem was caused by cws changehid which replaced
numerical hid's by strings and additionally removed the class SmartId.
The testtool code was adjusted ( but not completely )
So... the patch imo is not ideal, . It appears that there are still
hid(s) that are stringified numbers ( or at least that's what the
testtool code expects and it does use at least 1 hid file with such
numbers ) and now the testtool code goes to extra trouble to convert
between strings/numbers. I would guess this probably makes the testtool
slower. The testool code should be changed/fixed on master to deal with
the new reality, however for 3.4 I think the attached patch is the
safest option.
I'm looking for someone to bless/approve ( and or ) commit the patch to
the 3.4 branch
thanks,
Noel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: testoolfix-working-2.diff
Type: text/x-patch
Size: 26435 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110920/3baa626e/attachment-0001.bin>
More information about the LibreOffice
mailing list