[Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391

Caolán McNamara caolanm at redhat.com
Wed Sep 21 04:36:13 PDT 2011


On Wed, 2011-09-21 at 14:53 +0400, Ivan Timofeev wrote:
> Ok! Problems with incorrect pasting eliminated. But one problem still exists...
> If in brochure mode we input range, that is incorrect at all (e.g.
> "foo") or starts with illegal characters (e.g. "foo1-4"), previous
> range will be lost.

Isn't it a good thing that the previous range isn't the one selected
anymore  when an invalid range has been entered ?

I mean, this way if I type in "1-4" in brochure or normal mode and then
edit it to be "foo1-4" I get "no pages" which seems a good thing. Its
the same result a user would get if they entered "foo1-4" as the initial
range text so nice an consistent regardless of the order in which the
range text is edited.

Retaining the last-valid range entered seems dangerous to me, in the
sense that anything else that processes the range text won't get the
same results as the dialog claims it gives.

C.



More information about the LibreOffice mailing list