[Libreoffice] [REVIEW] simple fix for vcl glyph part ?

[julien2412]

Hello,

In vcl, I've got this :
/home/maryline/compile-libreoffice/libo/vcl/source/glyphs/graphite_layout.cxx:
In member function ‘void GraphiteLayout::fillFrom(gr_segment*,
ImplLayoutArgs&, float)’:
/home/maryline/compile-libreoffice/libo/vcl/source/glyphs/graphite_layout.cxx:333:49:
error: comparison between signed and unsigned integer expressions
[-Werror=sign-compare]
/home/maryline/compile-libreoffice/libo/vcl/source/glyphs/graphite_layout.cxx:334:48:
error: comparison between signed and unsigned integer expressions
[-Werror=sign-compare]
/home/maryline/compile-libreoffice/libo/vcl/source/glyphs/graphite_layout.cxx:343:56:
error: comparison between signed and unsigned integer expressions
[-Werror=sign-compare]
/home/maryline/compile-libreoffice/libo/vcl/source/glyphs/graphite_layout.cxx:357:49:
error: comparison between signed and unsigned integer expressions
[-Werror=sign-compare]
cc1plus: all warnings being treated as errors

It's due to the commit 162676cb6a940636e958b5787a626d814865ab86.

example of code :
           size_t bFirstChar = gr_cinfo_base(gr_seg_cinfo(pSegment,
nFirstCharInCluster));
            if (mnSegCharOffset + bFirstChar >= mnMinCharPos &&
                mnSegCharOffset + bFirstChar < mnEndCharPos)

I propose the patch below with static cast but perhaps all the variables
should be of the same type (unsigned int or signed int).

http://nabble.documentfoundation.org/file/n3359780/patch_glyph.txt
patch_glyph.txt 

If the static cast is ok, I can commit and push on master.

Julien.


--
View this message in context: http://nabble.documentfoundation.org/REVIEW-simple-fix-for-vcl-glyph-part-tp3359780p3359780.html
Sent from the Dev mailing list archive at Nabble.com.