[Libreoffice] [PATCH] ant/dmake to gbuild conversions

Norbert Thiebaud nthiebaud at gmail.com
Fri Sep 23 02:28:14 PDT 2011


On Thu, Sep 22, 2011 at 4:09 PM, Rene Engelhard <rene at debian.org> wrote:
> On Thu, Sep 22, 2011 at 04:38:35PM -0400, Peter Foley wrote:
>> I've attached two ant/dmake to gbuild conversions. Review would be
>> appreciated.
>
> Well, as people already said, ant is the standard tool for Java "make".
> I'd disagree to change this.

Well, Peter asked the question on the list before starting to work on
it and and the consensus was that for these limited cases the benefit
outweighed the cost.


> In this case, you also (by a quick skimming
> over the patch, maybe I oversaw it, but..) lost important parts of
> makefile.mk - like the Class-Path: fixing.

I'm really not versed in Java related thing.. but there is a
gb_Jar_set_jarclasspath() function. doesn't that already do the
necessary 'fixing' ?

Norbert


More information about the LibreOffice mailing list