[Libreoffice] [PATCH][PUSHED] Fix for fdo#39898: don't crash on some invalid MathML objects

Caolán McNamara caolanm at redhat.com
Mon Sep 26 05:02:28 PDT 2011


On Fri, 2011-09-23 at 22:36 +0400, Ivan Timofeev wrote:
> 2011/9/23 Caolán McNamara <caolanm at redhat.com>:
> > Looks sane to me. A good catch, pushed now.
> 
> He-he, I forgot to consider absolutely crazy cases - if
> <mmultiscripts> element is empty at all. Should this be fixed?

Probably, can't ever be too safe on anything which is basically content
controlled by the outside world I suppose. There's always something that
manages to find its way through the logic cracks eventually. Pushed this
now.

In that vein
- if (rNodeStack.Count() == nElementCount)
+ if (rNodeStack.Count() <= nElementCount)
doesn't hurt either I think.

C.



More information about the LibreOffice mailing list