[Libreoffice] Pb with lightproof

[Kálmán „KAMI” Szalai]

Hi!

Thank you for the fix!

The extension naming and copy to the solver done in download script:

# Extensions copy
echo "Copy extensions to their location ..."
for pack in $BARCODE_EXTENSION_PACK $DIAGRAM_EXTENSION_PACK
$VALIDATOR_EXTENSION_PACK $WATCH_WINDOW_EXTENSION_PACK
$NUMBERTEXT_EXTENSION_PACK $HUNART_EXTENSION_PACK $TYPO_EXTENSION_PACK
$GOOGLE_DOCS_EXTENSI$
    check_file $TARFILE_LOCATION/$pack
    packfilename=`echo "$pack" | cut -f 2- -s -d - | cut -f 1 -d _`
    echo "Copy extension: '$pack' as '$packfilename.oxt' ..."
    mkdir -p $SRC_ROOT/extras/source/extensions/ || exit 1
    cp $TARFILE_LOCATION/$pack
$SRC_ROOT/extras/source/extensions/$packfilename.oxt || exit 1
done

If we want to use

0ab55ac8e88f04258f1d3e79e984382f-lightproof-en_US-0.1.oxt

form, we might use this:
    packfilename=`echo "$pack" | cut -f 2-3 -s -d - | cut -f 1 -d _`

That provides
lightproof-en_US
as output.

If you agree wit this change I will prepare a patch and rename
Lightproof files in scp module.


KAMI

On 09/23/2011 10:49 PM, julien2412 wrote:
> Hello,
>
> In the commit 7dff26aa099aa97c7bfc03806ba8160a9d7e945c, I had fixed a typo :
> -            [en-US],
> [LIGHTPROOF_EN_US_PACK="0ab55ac8e88f04258f1d3e79e984382f-lightproof-en-US_0.1.oxt"],
> +            [en-US],
> [LIGHTPROOF_EN_US_PACK="0ab55ac8e88f04258f1d3e79e984382f-lightproof-en_US-0.1.oxt"],
>
> I don't know if there's a link with my fix but then now with a "make
> dev-install" or a build in smoketoo_native, I've got this :
>  ... analyzing modules ... 
> ------------------------------------
> ... languages en-US ... 
> ... analyzing files ...
> ERROR: The following files could not be found: 
> ERROR: File not found: lightproof-en-US.oxt
> ... cleaning the output tree ...
>
> A research in my local repository gives this :
> maryline at maryline:~/compile-libreoffice/libo$ find . -name "lightproof*"
> ./solver/unxlngi6/bin/lightproof-hu.oxt
> ./solver/unxlngi6/bin/lightproof-ru.oxt
> ./solver/unxlngi6/bin/lightproof-en.oxt
> ./extras/source/extensions/lightproof-hu.oxt
> ./extras/source/extensions/lightproof-ru.oxt
> ./extras/source/extensions/lightproof-en.oxt
>
> An Opengrok research of lightproof-en-US shows this :
> directory_extensions.scp 	97 DosName (en-US) = "lightproof-en-US";
> file_extensions.scp 	109 Name (en-US) = "lightproof-en-US.oxt";
>
> Now either, lightproof-en.oxt should be renamed in lightproof-en-US.oxt or
> the 2 scp files should be changed.
>
> Any ideas ?
>
> Julien.
>
> --
> View this message in context: http://nabble.documentfoundation.org/Pb-with-lightproof-tp3363021p3363021.html
> Sent from the Dev mailing list archive at Nabble.com.
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110926/6bd11110/attachment.pgp>