[Libreoffice] about unusedcode.easy

Norbert Thiebaud nthiebaud at gmail.com
Fri Sep 30 03:10:16 PDT 2011


On Fri, Sep 30, 2011 at 3:26 AM, Caolán McNamara <caolanm at redhat.com> wrote:
> On Fri, 2011-09-30 at 02:15 -0500, Norbert Thiebaud wrote:
>> When removing 'unused' code using unusedcode.easy, if you have an
>> accessor pair GetFoo()/SetFoo() and only one of these is unused,
>> please do not delete it.
>
> Why :-)

because then I won't have to resurrect the code when trying to merge
patches... :-)

but more generally: either the accessor is not useful and both set and
get can go, or it is and the fact that one side is not used is more a
signe that someone is not using it when it should or not using it
_yet_

Norbert


More information about the LibreOffice mailing list