[PATCH] Fix RTF list level text follow
Miklos Vajna
vmiklos at suse.cz
Mon Apr 2 02:16:44 PDT 2012
Hi Brennan,
On Sat, Mar 31, 2012 at 03:37:20PM -0700, Brennan T Vincent <brennanv at email.arizona.edu> wrote:
> RTF documents including lists now have the list level text ("1." or
> similar) followed by the correct thing (space, tab, or nothing) as
> specified in the document, whereas previously they were always followed by
> tab.
>
> I also updated the RTF exporter to correctly save RTF files containing
> non-default values for this parameter.
Thanks for the patch! It looks mostly correct,
> diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.hxx b/writerfilter/source/rtftok/rtfdocumentimpl.hxx
> index eb7e27a..4a2f549 100644
> --- a/writerfilter/source/rtftok/rtfdocumentimpl.hxx
> +++ b/writerfilter/source/rtftok/rtfdocumentimpl.hxx
> @@ -286,6 +286,9 @@ namespace writerfilter {
> /// List of character positions in leveltext to replace.
> std::vector<sal_Int32> aLevelNumbers;
>
> + /// What to follow the number in a list by. 0: tab; 1: space; 2: nothing
> + int nLevelFollow;
Except this: is this really needed? As far as I see, it's not used.
Also:
- Please do a 'git commit -a', and 'git format-patch -1', and send us
the result, not the output of 'git diff', as described here:
http://wiki.documentfoundation.org/Development#Preparing_patches
- Lastly, can you confirm that your contribution is provided under the
project license?
Sending a mail to the list, saying:
"All of my past and future contributions to the LibreOffice project are
under LGPLv3+/GPLv3+/MPL until further notice."
should be enough. (You only need this once.)
Miklos
More information about the LibreOffice
mailing list