[PATCH] EasyHack Bug 46610

Daniel Bankston daniel.dev.libreoffice at gmail.com
Tue Apr 3 20:39:43 PDT 2012

Lubos Lunak wrote:
> Looks good to me, I only removed the return's at the end of function, as
> they 
> are superfluous in void functions. Pushed, thank you.

Oops, I guess I got too robotic in that respect when I was changing the
return statements.  Thanks.

> It seems to me you are correct. I've added !IsEmpty() check to the if(), 
> which should do what the original author wanted.

I'm still a little worried about that aClip object that is being intersected
with aRegion which is now on line 673 but was originally in the conditional
on the line below.  The reason I'm worried is because the aClip object is
used again on line 697.  I don't know if the original author knew that
he/she was intersecting aClip with aRegion on line 673.  So what I'm asking
is: Should we completely remove SetClipRegion( aClip ) on line 673?  Sorry
if you already considered that before when you replied and pushed the patch. 

View this message in context: http://nabble.documentfoundation.org/PATCH-EasyHack-Bug-46610-tp3879786p3883107.html
Sent from the Dev mailing list archive at Nabble.com.

More information about the LibreOffice mailing list