[PUSHED][REVIEW 3-5] fdo#40021 don't let CSV import get confused by erroneous HTML detection

Eike Rathke erack at redhat.com
Thu Apr 5 07:47:14 PDT 2012


Hi Kohei,

On Wednesday, 2012-04-04 21:45:26 -0400, Kohei Yoshida wrote:

> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5eadc6aaafec92df23c57e258882a2c98ece0ad
> > that fixes https://bugs.freedesktop.org/show_bug.cgi?id=40021
> 
> Looks safe since it only changes the order of evaluation.

Well, that's the most fragile thing in filter detection ;-)

> I couldn't cleanly cherry-pick it from master to the 3-5 branch due to
> some conflict, though.

A change from ByteString to OString in between.

> But feel free to port this change to the 3-5
> branch, and push it with my sign-off.

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=c2a26cf9dab637c292e431d5cdf7bab5bbda571d

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120405/8825d254/attachment.pgp>


More information about the LibreOffice mailing list