[PUSHED] Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator

Jan Holesovsky kendy at suse.cz
Fri Apr 6 10:15:50 PDT 2012

Hi Szabolcs,

I've pushed your megapatch removing tons of equalsAsciiL :-)  I've split
it to several chunks to be able to automate at least part of the review:


Should you do more such changes, the more you can automate using a
script, the better, the review took me several hours; and we still have
quite some RTL_CONSTASCII_STRINGPARAM's left ;-)  Should you do more
manual patches, please try to keep them in some reasonable size, 1.5M
patch is not optimal for review...

I believe I caught all the mistakes that appeared there; no doubt you
must have spent incredible effort on that, so no wonder there was one or
2 typos there :-)  [I told you about them on the IRC, nothing else

Unfortunately I was unable to push your other patch, I've got no more
time for that - please send the link to the mailing list.

Thank you a lot for that!

All the best,

More information about the LibreOffice mailing list