[PATCH] Kill VbaFontBase::get/setUnderline

Gábor Stefanik netrolller.3d at gmail.com
Sat Apr 7 12:15:30 PDT 2012

On Sat, Apr 7, 2012 at 8:36 PM, Miklos Vajna <vmiklos at suse.cz> wrote:
> Hi Gábor,
> On Sat, Apr 07, 2012 at 07:30:42PM +0200, Gábor Stefanik <netrolller.3d at gmail.com> wrote:
>> Unused code removal.
> Hm, are you sure this is right, without removing the
> Underline attribute from oovbaapi/ooo/vba/XFontBase.idl? (But simply
> removing an attribute from there may break the ABI, I'm not sure.)

It definitely does compile and run for me - however, if you mean it
may cause regressions in functionality, then why is this in

>> Signed-off-by: Gábor Stefanik <netrolller.3d at gmail.com>
> You can leave this out for patches against master, we use Signed-off-by
> for stable reviews only.

Sorry, it came out of habit back from my Linux kernel days.

> Miklos
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

More information about the LibreOffice mailing list