[REVIEW:3-5] "Redundant assignment" in oox

julien2412 serval2412 at yahoo.fr
Sat Apr 7 12:32:04 PDT 2012


Cppcheck reported this :
[oox/source/vml/vmlformatting.cxx:251]: (warning) Redundant assignment of
"nModToken" in switch
Here are the lines :
    249             switch( AttributeConversion::decodeToken(
aColorIndex.copy( 0, nOpenParen ) ) )
    250             {
    251                 case XML_darken:    nModToken = XML_shade;
    252                 case XML_lighten:   nModToken = XML_tint;
    253             }

I pushed a fix on master c893a820c447c9014d35597a37c3220c261e35ae to just
add a break at the end of line 251.

could it be useful to push this on 3.5 branch this trivial fix ?


View this message in context: http://nabble.documentfoundation.org/REVIEW-3-5-Redundant-assignment-in-oox-tp3893277p3893277.html
Sent from the Dev mailing list archive at Nabble.com.

More information about the LibreOffice mailing list