Cppcheck reports "Same expression on both sides of '|'" on basctl module

julien2412 serval2412 at yahoo.fr
Sat Apr 7 16:25:41 PDT 2012


Hello,

On master, cppcheck reported this :
[basctl/source/basicide/bastypes.cxx:269] ->
[basctl/source/basicide/bastypes.cxx:269]: (style) Same expression on both
sides of '|'.
Here are the lines :
    266 BasicDockingWindow::BasicDockingWindow( Window* pParent, const
ResId& rResId ) :
    267     DockingWindow( pParent, rResId )
    268 {
    269     SetStyle( WB_BORDER | WB_3DLOOK | WB_DOCKABLE | WB_MOVEABLE |
    270                             WB_SIZEABLE | WB_ROLLABLE |
    271                             WB_DOCKABLE | WB_CLIPCHILDREN );
    272 }

It's quite recent, 1 month ago with commit
0e8eb19a53338c83dab7fe19e2f23bcaecd52077.
I've got not idea, if we can just remove WB_DOCKABLE or if it should be
replaced by another constant.

Any advice ?

Julien.

--
View this message in context: http://nabble.documentfoundation.org/Cppcheck-reports-Same-expression-on-both-sides-of-on-basctl-module-tp3893608p3893608.html
Sent from the Dev mailing list archive at Nabble.com.


More information about the LibreOffice mailing list