Cppcheck reports "Same expression on both sides" in writerfilter module

Lubos Lunak l.lunak at suse.cz
Sun Apr 8 10:26:30 PDT 2012

On Sunday 08 of April 2012, julien2412 wrote:
> Hello,
> On master repo, cppcheck reported this :
> [writerfilter/source/filter/ImportFilter.cxx:227] ->
> [writerfilter/source/filter/ImportFilter.cxx:227]: (style) Same expression
> on both sides of '||'
> So because of the 2 things noticed, I think there should be both and so
> just replace "1" by "2" and have "SERVICE_NAME2" as second operand.
> Perhaps I'm wrong or missed something, any idea ?

 No, your analysis looks correct to me, feel free to push the fix.

 Lubos Lunak
 l.lunak at suse.cz

More information about the LibreOffice mailing list