[PUSHED][PATCH] Kill VbaFontBase::get/setUnderline

Caolán McNamara caolanm at redhat.com
Tue Apr 10 06:12:32 PDT 2012

On Tue, 2012-04-10 at 09:43 +0200, Miklos Vajna wrote:
> On Sat, Apr 07, 2012 at 09:15:30PM +0200, Gábor Stefanik <netrolller.3d at gmail.com> wrote:
> > > Hm, are you sure this is right, without removing the
> > > Underline attribute from oovbaapi/ooo/vba/XFontBase.idl? (But simply
> > > removing an attribute from there may break the ABI, I'm not sure.)
> > 
> > It definitely does compile and run for me - however, if you mean it
> > may cause regressions in functionality, then why is this in
> > unusedcode.easy?
> The easy suffix just means the function name is not something you can
> easily dlopen().

This one falls under note "c" of unusedcode.README. They are pure
virtuals (the = 0 in the declaration), and no-one is explicitly calling
the pure virtual impls. Seeing as a VbaFontBase cannot be instantiated,
something has to inherit from it and provide an implementation of those
pure virtuals, and its those implementation in the inherited classes
that will get called.

So, upshot is that the right fix is to drop the unused base-class
implementation of the pure-virtual, i.e.


More information about the LibreOffice mailing list