[PATCH] Grouping ScFormulaOptions

Kohei Yoshida kohei.yoshida at gmail.com
Tue Apr 10 07:42:45 PDT 2012

Hi Albert,

On Mon, Apr 9, 2012 at 6:31 PM, Albert Thuswaldner
<albert.thuswaldner at gmail.com> wrote:
> Hi Kohei,
> As said back in February:
> http://lists.freedesktop.org/archives/libreoffice/2012-February/027009.html
> here is a follow-on patch that "groups" the formula options in the
> same fashion as the print options.
> This is a quite straight-forward re-factoring of the code so it
> shouldn't be too hard to review.

I'm reviewing at the moment, but your patch doesn't apply cleanly
against latest master.  Is there any way you can update your patch
against recent enough master?

If you are too busy, that's fine.  I'll do my best to apply it
manually.  Just let me know.

I only took a cursory look, and your use of local variable is probably
ok, though I still need to make sure that it works as
expected....(which is why I need to apply the patch and run a quick



More information about the LibreOffice mailing list