[PATCH][REVIEW] gbuild conversion: idlc module
david.ostrovsky at gmx.de
Thu Apr 12 14:45:51 PDT 2012
thank you for your comments on my patch. I changed it accordingly.
*@Matúš:* thank you for your help on IRC.
Special usage gnu_getopt lib in windows:
Matúš proposed the follow simple solution to include in
$(eval $(call gb_Executable_use_libraries,idlcpp,\
1. HAVE_GETOPT is allways NO on windows
2. gnu_getopt is registered already on windows:
gb_Library_PLAINLIBS_NONE += [...] gnu_getopt [...]
and here solenv/gbuild/platform/WNT_INTEL_MSC.mk
3. original make file snippet was only active on windows
.IF "$(HAVE_GETOPT)" != "YES"
.IF "$(GUI)$(COM)" == "WNTMSC"
.ELIF "$(GUI)$(COM)" == "WNTGCC"
Having said that, how could we simplify the gnu_getopt treatment in
-------- Original Message --------
Subject: Re: [PATCH][REVIEW] gbuild conversion: idlc module
Date: Thu, 12 Apr 2012 06:33:19 +0200
From: David Tardon <dtardon at redhat.com>
To: David Ostrovsky <david.ostrovsky at gmx.de>
CC: Libreoffice-dev <libreoffice at lists.freedesktop.org>
On Wed, Apr 11, 2012 at 11:18:46PM +0200, David Ostrovsky wrote:
> this is gbuild conversion for idlc module.
Good. But it is not quite ready yet, see comments below.
> diff --git a/Repository.mk b/Repository.mk
> index 1a3851e..638f4f8 100644
> --- a/Repository.mk
> +++ b/Repository.mk
> @@ -31,6 +31,8 @@ $(eval $(call gb_Helper_register_executables,NONE, \
> bmp \
> bmpsum \
> cppunit/cppunittester \
> + idlc \
> + idlcpp \
> g2g \
> gencoll_rule \
> genconv_dict \
Both binaries should be registered in layer SDKBIN (because of
> +$(eval $(call gb_Executable_use_libraries,idlc,\
> + sal \
> + reg \
Originally idlc is linked with salhelper too. It is possible it is no
longer necessary, but it is also possible that it is necessary on a
different platform. (Nitpick: please, keep the libs sorted
> +$(eval $(call gb_Executable_use_linked_libs,idlcpp,\
> + gnu_getopt \
This is wrong: there is no unconditionally built library gnu_getopt. It
only worked for you because there is no function
gb_Executable_use_linked_libs either (it is called
gb_Executable_use_libraries) and your platform's libc has getopt .-)
You need to use gb_Executable_use_externals and add a new definition to
RepositoryExternals.mk for it, like:
# nothing needed
else # !HAVE_GETOPT
$(eval $(call gb_Helper_register_libraries,PLAINLIBS_NONE,\
endif # HAVE_GETOPT
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the LibreOffice