Automatic using ::rtl::OUString etc.

Stephan Bergmann sbergman at redhat.com
Fri Apr 13 01:41:04 PDT 2012


On 04/13/2012 10:24 AM, Tor Lillqvist wrote:
> On the other hand, any kind of duplication is always bad, isn't it, as
> is inconsistency. So isn't it, from that point of view, bad that some
> percentage of the source files contain those "using" statements
> (duplication), some a subset of them (inconsistency), others not, some
> use ::rtl::foo, others rtl::foo, etc etc. Any changes that would make
> the coding style more consistent and less verbose would be good in my
> opinion.

Inconsistency in this area is a direct consequence of C++'s somewhat 
TIMTOWTDI approach how to write names for things.  More consistent usage 
of using directives across the code base would definitely not hurt.  But 
if you wanted to enforce consistency, you would need to abandon 
namespaces.  (And note that Lubos' proposal would not automatically 
eliminate inconsistency, either, as writing "rtl::OUString" would 
technically still be allowed.)

Stephan


More information about the LibreOffice mailing list