[PUSHED] Re: [PATCH][REVIEW] gbuild conversion: idlc module

[Matúš Kukan]

Hi David

On 12 April 2012 23:45, David Ostrovsky <david.ostrovsky at gmx.de> wrote:
>
> thank you for your comments on my patch. I changed it accordingly.

nice patch, thanks

I pushed it with few modifications:
- removed new_style from CustomTarget
- also removed makefile.mk from inc/
- and please, could you be consistent with tabs vs. spaces, I've
cleaned tabs from Executable_idlc.mk

But it was good.

> Having said that, how could we simplify the gnu_getopt treatment in tools/Executable_rscdep.mk?

It was already done, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=40775ce183ac29e9598cbca59e995c7e77327a1a

Thanks,
Matúš