[PATCH] 2/2 List cleanup in SD

Lubos Lunak l.lunak at suse.cz
Fri Apr 13 09:46:00 PDT 2012

On Thursday 12 of April 2012, Rafael Dominguez wrote:
> This are the hardest ones to port, since the rExchangeList parameter uses
> the last position from InsertBookmarkAsPage in InsertBookmarkAsObject, so
> the best idea i came up with to avoid doing nasty stuffs was erase procesed
> objects in InsertBookmarkAsPage and add an extra parameter to
> InsertBookmarkAsObject that recalculates object count when rExchangeList
> has items but its manipulated by InsertBookmarkAsPage first like it occurs
> in function SdDrawDocument::InsertBookmark.

 Seems reasonable, to keep the behaviour of the old version. But the comment 
you added to the code next to the erasing probably doesn't explain much other 
than that the code is there for some reason, this comment above explains it 
better, so I've added it to the commit log message. Otherwise the patches 
looked good.

 Lubos Lunak
 l.lunak at suse.cz

More information about the LibreOffice mailing list