[PATCH] Replace SV_DECL_PTRARR_DEL by ptr_vector in WW8ListManager

Arnaud Versini arnaud.versini at gmail.com
Sat Apr 14 06:30:52 PDT 2012


This patch replace SV_DECL_PTRARR_DEL by a simple ptr_vector in

I'm not sure about this comment in the destructor, the object is always
destroyed, I think we should use a ptr_vector too, or don't destroy
unconditionally (*aIter).

    named lists remain in doc!!!
    unnamed lists are deleted when unused
    pLFOInfos are in any case destructed
    for(std::vector<WW8LSTInfo *>::iterator aIter = maLSTInfos.begin();
        aIter != maLSTInfos.end(); ++aIter)
        if ((*aIter)->pNumRule && !(*aIter)->bUsedInDoc &&
        delete *aIter;

Thanks in advance for reviewing

Best regards

Arnaud Versini
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120414/e0c12a3f/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-boost::ptr_vector-in-WW8ListManager-instead-of-SV_DECL_PTRARR_DEL.patch
Type: application/octet-stream
Size: 14261 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120414/e0c12a3f/attachment-0001.obj>

More information about the LibreOffice mailing list