[PATCH] Bug 48140 - [EasyHack] remove uno calls from xlsx import

Daniel Bankston [danthedev] daniel.dev.libreoffice at gmail.com
Sat Apr 14 21:20:59 PDT 2012

Hello, everyone,

I have attached my patches for EasyHack 48140.  I have taken baby steps, 
so this just the first part of completing EasyHack 48140.  I changed 
WorkbookHelper::createNamedRangeObject and createLocalNamedRangeObject 
to return ScRangeData* instead of Reference<XNamedRanged>, and then I 
adjusted all callers.  You will notice I commented the old code out 
instead of deleting it.  I did this as this is just partial update for 
the EasyHack.

I was able to successfully make sc with these changes.  "make -sr 
slowcheck" was also successful.  My own manual tests were also 
successful.  I tested by running calc and opening xlsx spreadsheets 
containing ranges with names.  I also created names for ranges and 
created names for cells in those spreadsheets.  I referred to those 
ranges and cells by name in other cells.

Although my tests were successful, I still fear that there is something 
that I may have missed due to my current beginner level of understanding 
of the sc model.  I am eager to see what suggestions you all may have.

When I have more time, I later plan to make similar changes to the 
database ranges and eventually remove all UNO calls in these methods 
where possible.  (School semester is still in for me and quite busy as 
it nears the end.)


Daniel Bankston

More information about the LibreOffice mailing list