[REVIEW][3-5] Re: [PUSHED][3-5] fdo#38635: sw: printing border lines gaps regression

Michael Stahl mstahl at redhat.com
Tue Apr 17 13:46:20 PDT 2012


On 17/04/12 10:24, Miklos Vajna wrote:
> On Mon, Apr 16, 2012 at 05:24:44PM +0200, Michael Stahl <mstahl at redhat.com> wrote:
>> proposing for libreoffice-3-5:
>>
>> with the old border painting code, there is a special case for printing
>> where the vertical borders are shortened so they don't overlap with the
>> horizontal borders (the old borders were rectangular).  this seems to be
>> completely unnecessary and detrimental with the new way the corners are
>> painted (slanted), and causes huge gaps in the corners.
>>
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=502c93143ef29989692ca3e63e3e6abc255fd53f
>>
>> with the fix the huge gap is removed
> 
> Pushed now.

thanks; as mentioned in the bug report there was still a small gap
remaining with the above fix, which i've now tracked down to the
start/end positions of the horizontal and vertical lines not being equal.

proposing the fix for libreoffice-3-5

http://cgit.freedesktop.org/libreoffice/core/commit/?id=b08e9f3023e9ea1ca0926334becac939ca8fdfac



More information about the LibreOffice mailing list