[Libreoffice-commits] .: writerfilter/source

[Norbert Thiebaud]

On Wed, Apr 18, 2012 at 2:52 AM, Lubos Lunak <l.lunak at suse.cz> wrote:
> On Wednesday 18 of April 2012, Tor Lillqvist wrote:
>> > MacOSX is one of the few platform that has consistently been built
>> > with --enable-werror.
>> > removing the benefit of it just for a micro-optimization seems an
>> > overkill.
>>
>> I agree with Norbert here. The more tinderboxes we have that (continue
>> to) use --enable-werror, the better.  (If with significantly different
>> compilers, even better.)
>
>  I have no problem with different, I have a problem with broken. There's no
> benefit of fixing warnings for a compiler that is 6 years old. If the warning
> were valid, recent gcc would emit it too.
>
>  Or does that mean I should enable WaE for the MSVC tinderbox too? That should
> be some fun, with people even now not bothering to fix that build that much.

yes we should... at least we should try to get to the point we we could...

uncared for for Warnings are the forest that hide the tree... and
getting a 0-warning build is well worth few sub-optimal code point.

Norbert