[PATCH] Remove unused debug facilities from basebmp

Jan Holesovsky kendy at suse.cz
Wed Apr 18 08:58:56 PDT 2012

Hi Gabor,

On 2012-04-14 at 11:58 +0200, Lubos Lunak wrote:

> > Remove debug dumping facility from basebmp.
> From the patch:
> "Used in vcl/headless/svpgdi.cxx when OSL_DEBUG_LEVEL > 2"
>  And it indeed is. Moreover it looks like quite useful debugging 
> functionality, so I don't think it should be removed just because 
> unusedcode.easy lists it. It should always be checked whether what's listed 
> should really be removed, the file is just automatically generated and it is 
> fallible.

Actually, in cases like this, it is best to enclose the "offending" code
with #if OSL_DEBUG_LEVEL > 2 too, so that it is compiled only when it is
supposed to be called - can you update your patch that way, please?

Thank you,

More information about the LibreOffice mailing list