[PATCH] Use global constants for initial tab count bounds checking

Albert Thuswaldner albert.thuswaldner at gmail.com
Wed Apr 18 10:15:22 PDT 2012

Hi Kohei,
Sorry for double posting, forgot to CC the list.

On Wed, Apr 18, 2012 at 02:21, Kohei Yoshida <kohei.yoshida at gmail.com> wrote:
> On Wed, 2012-04-18 at 00:41 +0200, Albert Thuswaldner wrote:
>> Hi Kohei,
>> This patch makes the bounds checking of the initial tab count more
>> consistent with the actual limits.
> Actually we intentionally limit the number of initial sheets to 1024
> even though the document can have up to 10000 sheets.
> This is to prevent users to accidentally set the initial sheets too
> high, since that could cause the memory usage of even a blank document
> to exceed the available system memory, and it becomes very difficult to
> revert the setting once it's set.

Ok, good to know. IMHO it is even more important to sort this thing
out. I've updated my patch with a new proposed solution.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-global-constants-for-initial-tab-count-bounds-ch.patch
Type: text/x-patch
Size: 3088 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120418/c62b8375/attachment-0001.bin>

More information about the LibreOffice mailing list