[PUSHED-3-5 REVIEW-3-5-3] fdo#46687 fix find toolbar crash ...

Bjoern Michaelsen bjoern.michaelsen at canonical.com
Thu Apr 19 15:01:02 PDT 2012


On Thu, Apr 19, 2012 at 05:38:09PM +0200, Bjoern Michaelsen wrote:
> On Thu, Apr 19, 2012 at 02:38:47PM +0100, Michael Meeks wrote:
> > 	I had a poke at this heisenbug (that disappears with SAL_SYNCHRONIZE
> > set), and - after a bit of xtracing, discovered that (rather
> > un-satisfyingly) that the attached patch fixes it; it should be entirely
> > harmless if not entirely explained [ the error push/pop should stop this
> > happening anyway ].
> > 
> > 	Tripple review for libreoffice-3-5-3 and one more for libreoffice-3-5
> > if possible.
> > 
> > From 6d97ea37bba52b21648c91276bc9281d06cdd148 Mon Sep 17 00:00:00 2001
> 
> Patch itself looks good, doing a build right now with it. Thanks so much for
> this. I would love to give you a signoff right away, but gotta run now. I will
> report back in the evening.

Tested (on master) -- works beautifully.

Pushed to -3-5, still needs two signoffs for 3-5-3.

Best,

Bjoern


More information about the LibreOffice mailing list