[REVIEW][3-5] fdo#38215: sw: fix consecutive border line gaps regression

Caolán McNamara caolanm at redhat.com
Fri Apr 20 05:11:48 PDT 2012

On Mon, 2012-04-16 at 17:19 +0200, Michael Stahl wrote:
> this fixes a regression in painting border lines in LO 3.4, leading to
> small visible gaps between borders of consecutive paragraphs, and is
> proposed for libreoffice-3-5.
> fixed by re-implementing the merging of border lines that are less than
> 1.5 pixel apart that was done in the old paint implementation.

> http://cgit.freedesktop.org/libreoffice/core/commit/?id=0868a0155a2b57daf7b862d120aead0458372b17

So, looks reasonable to me, except it doesn't apply cleanly to 3-5, can
you tweak it to apply to 3-5 and we can push that then to 3-5. And why
the change from ::std::swap to a manual push_back of each line to new
SequenceAsVector followed by clear on the original ?

> http://cgit.freedesktop.org/libreoffice/core/commit/?id=1d5e263a129c56e561ce145bad9749027c583a75
this at least got pushed along with fdo#38635: sw: printing border lines
gaps regression


More information about the LibreOffice mailing list