[PATCH] Some fixes for Clang warnings

[Catalin Iacob]

I tried to build with Clang and --enable-werror to see if that finds
any bugs. Attached are results so far; there is still quite some to
compile and Clang also consistently crashes on a file.

All this is with self compiled Clang from trunk revision 152134 from 6
March 2012.

Only patch 6 solves a real bug, but in CLucene not LO. I sent the same
patch upstream but got no response so far.

There are quite some more "implicit conversion changes signedness"
warnings left in connectivity, is it ok to do larger changes like
patches 8 and 9 do (switch method arguments or class members from
signed to unsigned if that makes sense for example) or should I just
silence the warnings with casts?

Thanks,
Catalin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-WaE-Clang-empty-forloop-body.patch
Type: application/octet-stream
Size: 969 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120422/1934ad47/attachment-0009.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-WaE-Clang-unused-variable.patch
Type: application/octet-stream
Size: 946 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120422/1934ad47/attachment-0010.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-WaE-Clang-unused-variable.patch
Type: application/octet-stream
Size: 1583 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120422/1934ad47/attachment-0011.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-WaE-Clang-adding-int-to-a-string-does-not-append-to-.patch
Type: application/octet-stream
Size: 1428 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120422/1934ad47/attachment-0012.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-WaE-Clang-C-linkage-warning.patch
Type: application/octet-stream
Size: 1432 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120422/1934ad47/attachment-0013.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-WaE-patch-CLucene-to-avoid-Clang-unused-parameter-wa.patch
Type: application/octet-stream
Size: 1566 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120422/1934ad47/attachment-0014.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-WaE-Clang-expression-result-unused.patch
Type: application/octet-stream
Size: 1495 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120422/1934ad47/attachment-0015.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-WaE-Clang-implicit-conversion-changes-signedness.patch
Type: application/octet-stream
Size: 1748 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120422/1934ad47/attachment-0016.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-WaE-Clang-implicit-conversion-changes-signedness.patch
Type: application/octet-stream
Size: 5986 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120422/1934ad47/attachment-0017.obj>