[PATCH] fdo#39643: Remove --disable-strip-solver configure option

d.ostrovsky at idaia.de d.ostrovsky at idaia.de
Tue Apr 24 02:33:33 PDT 2012


Zitat von Lubos Lunak <l.lunak at suse.cz>:

> On Tuesday 24 of April 2012, Stephan Bergmann wrote:
>> On 04/23/2012 06:17 PM, Petr Mladek wrote:
>> > I am not sure but I think that strip reduces size of binaries even when
>> > you build without -g. It just removes something less important.
>>
>> strip removes the table of internal symbols.  The effect is that
>> backtrace information (whether produced by LO's unmaintained automatic
>> crash reporting or manually by a capable user) becomes hard to use (or
>> even next to useless).
>
>  I remember that used to be the case a looong time ago, but is it still valid
> today? Assuming this is about means such as the backtrace() call, that is
> AFAIK next to useless for normal builds anyway, as it just does not work with
> features like hidden visibility. I think debug info is the only usable way to
> get backtraces on Linux these days.
>
>  Morever, if I pick e.g. libswlo.so from my devel build and strip  
> it, the only
> difference is .debug* sections removed, so quite possibly even that table of
> internal symbols is a thing of the past.
>

Do we agree about to drop the striping code from ooinstaller?
As far as I can see the use cases we have are:

Use Case (UC) 1: distro maintainer would build without -g, nothing to
be stripped.

UC 2: developer with change, compile, test cycle would build with -g
and install LO with make install oder make dev-install. He wants
definitely preserve the symbols.

UC 3: developer compiles it with symbols and want provide the build
artifacts to somebody to test.
It could be the only justification to provide a new make target
"strip-and-install". But the tests with stripped
artifacts are useless, no deeper analysis is possible. Another
argument for not to strip even in this case is a new configure option
that was introduced in the last hackfest to selectively specify the
list of libraries to build with symbols. With this option not the
whole LO but only a couple of libs would be built with symbols.

If I've not forgotten some use cases, I would suggest to completely
remove the whole stripping stuff from ooinstaller code.

David


More information about the LibreOffice mailing list