[PUSHED][REVIEW:3-5] fdo#48023 fix RTF import of Russian characters without an encoding specified

Caolán McNamara caolanm at redhat.com
Tue Apr 24 09:34:17 PDT 2012


On Tue, 2012-04-24 at 17:40 +0200, Miklos Vajna wrote:
> On Tue, Apr 24, 2012 at 02:15:53PM +0100, Caolán McNamara <caolanm at redhat.com> wrote:
> > Can you merge that with (the equally horrible equivalent and partial
> > hack) in ww8par.cxx (search for LANGUAGE_RUSSIAN) and put it someplace
> > shared ?
> 
> Sure - does the attached patch looks sane? It definitely works with my
> Russian test RTF doc, the ww8 part is only compile-tested.

Well, I was thinking something more like a
getBestTextEncodingFromLanguage() and keeping the "I know what language
this text is in anyway" info in the ww8 filter and passing it in the
default locale language for the rtf case in writerfilter. I can adapt it
if you want to push the above to master.

> the originally proposed smaller change in -3-5.

fair enough, pushed that to 3-5 anyway.

C.



More information about the LibreOffice mailing list