[PUSHED] Some fixes for Clang warnings

Catalin Iacob iacobcatalin at gmail.com
Tue Apr 24 14:26:37 PDT 2012


On Mon, Apr 23, 2012 at 2:39 PM, Stephan Bergmann <sbergman at redhat.com> wrote:
> Only 0002-WaE-Clang-unused-variable.patch and
> 0003-WaE-Clang-unused-variable.patch I did not push.  Can you change them as
> I suggested above (or just let me know if you want me to do that)?

I attached updated patches which use SAL_WARN_IF instead of
OSL_ENSURE, warnings are indeed gone and hopefully the messages are a
bit better than before.

The 3rd one links to the CLucene patch proposed upstream as you suggested.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-WaE-Clang-unused-variable.patch
Type: application/octet-stream
Size: 1301 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120424/11dfb966/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-WaE-Clang-unused-variable.patch
Type: application/octet-stream
Size: 2023 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120424/11dfb966/attachment-0004.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Mention-that-the-CLucene-patch-was-also-sent-upstrea.patch
Type: application/octet-stream
Size: 1051 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120424/11dfb966/attachment-0005.obj>


More information about the LibreOffice mailing list