[PATCH] fdo#39643: Remove --disable-strip-solver configure option

Petr Mladek pmladek at suse.cz
Thu Apr 26 01:59:35 PDT 2012

Hello David,

David Ostrovsky píše v Čt 26. 04. 2012 v 08:07 +0200:
> thank you for your review and your comments.
> Here is a new version with these issues fixed:
> 1. no strip in solenv/bin/deliver.pl any more
> 2. solenv/bin/modules/installer preserves striping code
> 3. there is a new target install-strip that do strip during installation 
> process.

Perfect! It is exactly how I imagined it :-)

> Question: i can not see where $strip var in ooinstall is parsed (in 
> make_installer.pl call)?
> if ($ENV{BUILD_TYPE} =~ m/ODK/) {
>      print "Running SDK installer\n";
>      system ("cd $ENV{SRC_ROOT}/instsetoo_native/util ; " .
>      "perl -w $ENV{SOLARENV}/bin/make_installer.pl " .
>      "-f openoffice.lst -l en-US -p LibreOffice_SDK " .
>      "-u $tmp_dir " .
>      "-buildid $BUILD $destdir $strip $msi " .
>      "-simple $path") && die "Failed to install: $!";
> }
> For the new param in Makefile ooinstall -strip to be passed to
> make_installer.pl I have to parse it myself in ooinstall, right?

Yes, I have added is, see the attached patch.

I have also added -strip option when generating the LibreOffice
installation set to make sure that the official build is the same as it
was before.

I am going to double check it in a clean build and push it within next 3
hours or so.

Thanks a lot for patience and great patch.

Best Regards,

More information about the LibreOffice mailing list