a stab at removing atl stuff. window experience needed.

Jesús Corrius jesus at softcatala.org
Fri Apr 27 06:05:55 PDT 2012

On Fri, Apr 27, 2012 at 1:28 PM, Caolán McNamara <caolanm at redhat.com> wrote:
> In an effort to make building under windows a pain-free as possible. I'm
> playing with removing the atl usage in embedserv seeing as MSVC2008
> Express doesn't come with it.

And mingw doesn't compile it...

There's also some problematic code in shellextensions, I think.

> a) I haven't a clue what embedserv even does, or how to test it ?

I used to develop COM+ stuff in plain C (much fun) like 10 years ago.
I just remember the basics but I surely remember how to test it. I can
help you with that. In fact, I will try the component this weekend if
I have some spare time. It would be a lot of fun.

> b) I see that we have...
> CComModule _Module;
> _Module.Init(ObjectMap, hInstance, NULL);
> ...
> _Module.Term();
> because I'm clueless, I'm wondering if this even makes sense when we
> have an empty OBJECT_MAP ?, or is still doing some necessary reference
> counting of the module itself ? I mean we could follow
> http://samscode.blogspot.com/2009/10/atl-removal-part-3-tackling-module-and.html and convert it over. But might be a bit silly to do that if its just some non-functional stub left over form some wizard generated code.

Right. If my memory serves me well, this code was almost an exact copy
of an MSDN old sample with a few changes here and there. So I wouldn't
be surprised if some parts of the code are just there because they
were in the sample.

The code in the blog post looks perfectly well to me. And yes,
everything you find there is required.

Jesús Corrius <jesus at softcatala.org>

More information about the LibreOffice mailing list