[PUSHED v2] fdo#42779: Implement icon theme lookaside directory

Michael Meeks michael.meeks at suse.com
Mon Apr 30 04:24:15 PDT 2012

Hi Gabor,

On Sun, 2012-04-29 at 04:56 +0200, Gábor Stefanik wrote:
> This enables overriding icons found in an images.zip file with ones in
> a directory named "images" next to the zip file.

	Looks lovely, as/when there are dev-builds we should poke the artists
about it so they know it's there & get them excited about it :-)

> Icon caching is also disabled when a lookaside directory is detected,
> so changes to the icons in the directory are applied immediately.

	So - one minor problem here is that, we do this system-call thrash for
each icon for a file that is not there :-) I'd rather prefer that we
require the images/ directory to exist at startup - if it is there, we
always do the lookups first in there and turn the cache off - otherwise,
we never look in there.

	Any chance of a minor follow-on tweak to do that ? the strace of a
normal startup without that directory should not have scads of opens
of .pngs.

> Icons in a lookaside directory currently always take precedence over
> ones in zip files.

	Thanks for that, can you close the easy-hack bug too ? :-)

	Nice work,


michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list