[REVIEW-3-6][REVIEW-3-6-x]fdo#52998 fdo#52999 MAB

[Eike Rathke]

Hi Noel,

On Thursday, 2012-08-02 14:32:16 +0100, Noel Power wrote:

> master:6068f2f7cf5d66c68241b3831851b413b2e0b3ba ( sorry don't have
> the cgit url as cgit is dead )

git show 6068f2f7cf5d66c68241b3831851b413b2e0b3ba | vim -
works fine ;-)

However, that is supposed to fix that comments disappear when saving to
.xls, correct (as bz is down as well ...) ? It doesn't for me in 3-6,
reloading the .xls the comment is gone. The patch itself looks correct,
but apparently there's more to it.

Placing a breakpoint there revealed that a XclExpNote record is never
added.. some seconds later: this if a note is on a cell without content
... notes are saved only for cells with content.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120802/284bffa9/attachment-0001.pgp>